cryptocoinjs / keccak

Keccak sponge function family
MIT License
86 stars 24 forks source link

Move native to optionalDependency? #11

Closed junderw closed 5 years ago

junderw commented 5 years ago

tiny-secp256k1 did so, and it at least allows failed installs to fallback on the JS as intended.

@fanatid thoughts?

Also kind of want to do something similar with node-secp256k1

fanatid commented 5 years ago

install command not work in some cases? https://github.com/cryptocoinjs/keccak/blob/bce5b58e8e5e3d17bcb681fa2814dbe8dd893841/package.json#L34

JS and native highly tied, they implement only basic API which extended by shared functions https://github.com/cryptocoinjs/keccak/blob/master/lib/api/index.js

junderw commented 5 years ago

apparently #3 tells me people are getting errors

junderw commented 5 years ago

Nevermind... I tested it myself in an alpine container... seems like an install script is better idea.

junderw commented 5 years ago

https://github.com/bitcoinjs/tiny-secp256k1/pull/41