search

cryptocoinjs / keccak

Keccak sponge function family
MIT License
86 stars 24 forks source link

node-addon-api (n-api) instead NAN #14

Closed fanatid closed 4 years ago

fanatid commented 4 years ago

Also added prebuilds compiled by GitHub Actions.

alcuadrado commented 4 years ago

Hey @fanatid, thanks for implementing this change. I'm trying to figure out which N-API version is required now, and hence, which node versions are supported, but I'm a little bit lots. Any hint? Thanks

fanatid commented 4 years ago

Hi @alcuadrado I decide stay with version 3, because 1 and 2 was available only under flag. https://nodejs.org/api/n-api.html#n_api_n_api_version_matrix NAPI_VERSION in binding.gyp: https://github.com/cryptocoinjs/keccak/blob/v3.0.0/binding.gyp#L52 node version in package.json: https://github.com/cryptocoinjs/keccak/blob/v3.0.0/package.json#L45

alcuadrado commented 4 years ago

Thanks for the quick answer! This info is really helpful :)