search

cryptocoinjs / keccak

Keccak sponge function family
MIT License
86 stars 24 forks source link

Replace stream with readable-stream #22

Closed ghost closed 3 years ago

ghost commented 3 years ago

21

samuveth commented 3 years ago

Very much needed for Vite!

dievardump commented 3 years ago

Could we have this merged so people not using webpack can use the library?

fanatid commented 3 years ago

@byterose thank you for PR, two questions:

  1. readable-stream should be added to package.json
  2. Is it possible to solve webpack issue with resolve.fallback? https://github.com/cryptocoinjs/keccak/issues/21#issuecomment-874092461
sirius651 commented 3 years ago 
Is it possible to solve webpack issue with resolve.fallback?

I tried to adding fallback, but it's not work. maybe above PR can work

ghost commented 3 years ago

@byterose thank you for PR, two questions:

  1. readable-stream should be added to package.json
  2. Is it possible to solve webpack issue with resolve.fallback? Transform not found? #21 (comment)
  1. I just pushed a commit to add readable-stream to package.json 🙂
  2. I tried to do this before I created this pr, but it didn't seem to work
fanatid commented 3 years ago

Thanks! Published as 3.0.2.