cryptodotis / irssi-otr

LibOTR functionality in Irssi.
GNU General Public License v2.0
183 stars 24 forks source link

Only the last message fragment is sent #21

Open weinholt opened 11 years ago

weinholt commented 11 years ago

When sending encrypted messages that need to be fragmented, only the last fragment is actually sent to the IRC server. I can reproduce this by connecting two irssi clients to the same IRC server, initiating an OTR session between them and sending an 80 character line from one client to the other. "/rawlog save" only shows the fragment that starts with "?OTR|...|...,00002,00002,".

I've tested this with irssi 0.8.15-5 and ibotr5 4.0.0-2 on Debian wheezy amd64 with irssi-otr v1.0.0-alpha1-5-g5f685aa from git.

dgoulet commented 11 years ago

This has been observed by some people in the last days indeed. Thanks for this. This is obviously a big priority.

dgoulet commented 11 years ago

This seems like an libotr upstream problem. I'm waiting for a patch to be accepted.

http://lists.cypherpunks.ca/pipermail/otr-dev/2013-January/001549.html

dgoulet commented 11 years ago

Still waiting for the patch to be upstream so I'll add it here since it's pretty trivial.

http://ev0ke.net/0001-Fix-pass-opdata-when-sending-message-fragment.patch

anarcat commented 11 years ago

Shouldn't this be closed, considering it's a bug in libotr?

dgoulet commented 11 years ago

I don't think so because this package does not work properly with upstream libotr and keeping this opened acknowledge the issue and even provide a fix. Until we see the fix in upstream libotr, I really think this should be kept open because other distros (like Arch or even Ubuntu) are not providing a fix for libotr.

dgoulet commented 11 years ago

Ok so this is upstream in libotr right now. We are putting pressure on them to release a new version with that fix so packages stop applying this custom patch. Once a release is done, we'll close this one!

anarcat commented 10 years ago

thanks! any timeline on that? or reference for the upstream issue, for that matter?

DrWhax commented 10 years ago

Ian needs to create a new libOTR release, it's upstream in the git repository.

anarcat commented 10 years ago

well, that's what i meant: do we know when they will do a new release or where their bugtracker is?

DrWhax commented 10 years ago

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

There isn't really a bugtracker, there is a mailinglist however[1] There is no indication of a new release, we can craft an email and ask them? :)

[1] http://lists.cypherpunks.ca/mailman/listinfo/otr-de -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBAgAGBQJSRtofAAoJELc5KWfqgB0C3aAH/jF4ErUbkSs7wp3Z/1O0byV2 SDTh0avv1qRexJgcXmmVoUkM9HlcWvBN48cQcS41LxX7Q/eoD7EtwpHvKbJd8xpw ZKDiacj1gZe+1KOA6PDpqTNqIrkLd52vBh4aUDPrMBLyBHQeKPj86xr8fE0xKaxc V4xvMA2JV92eGiNRugFCTWfT/iwh6HL4MhiwfFCDt/yHnJzCJSFnjfmpPALqYaqT tPH8xWewFbzrsFRKEdV0GKB1LkzPtDM1L/N0UYMmXDebKMMVho68XiGnxQ/WEEyS NvNY2vAsKTo810gzk9PANi6ccuFDV6UZa8kdkDDenNBSvyzZursaZYpKmMzOQLk= =F3xs -----END PGP SIGNATURE-----