search

cryptodotis / irssi-otr

LibOTR functionality in Irssi.
GNU General Public License v2.0
183 stars 24 forks source link

print instead of assert #37

Closed ghost closed 10 years ago

ghost commented 11 years ago

Instead of using assertions and crashing whole irssi, it would be more user-friendly to just print the location of the error and perhaps unload the module.

dgoulet commented 11 years ago

Usually, assert() in this code base represents code flow error that can trigger, if unnoticed, undefined behaviors, crash or even security issues.

Irssi OTR is still in alpha meaning that stability and security wise it needs more testing. Assert are usually removed in stable packaging (with the NDEBUG macro undefined).

If you come upon an assert() statement that should actually be an error, let us know.

dgoulet commented 10 years ago

Been open for 3 months, I'll close this one. If this "issue" comes up again, we'll reopen. Thanks!