cryptodotis / irssi-otr

LibOTR functionality in Irssi.
GNU General Public License v2.0
183 stars 24 forks source link

libotr 4.1.x support #50

Closed ysangkok closed 9 years ago

ysangkok commented 9 years ago

The readme says that irssi-otr needs libotr 4.0.x. This is not the latest version and it is an inconvenience.

andreasstieger commented 9 years ago

Works fine with libotr 4.1.0, there is no special support required. Do you have a specific issue with this version?

ysangkok commented 9 years ago

I just tried building with the new version, and it seems to work. But I'm uncomfortable disobeying the instructions.

dgoulet commented 9 years ago

I just updated the README that contained some old info.

Thanks for the report!

On 12 Jan (11:19:19), Janus Troelsen wrote:

I just tried building with the new version, and it seems to work. But I'm uncomfortable disobeying the instructions.


Reply to this email directly or view it on GitHub: https://github.com/cryptodotis/irssi-otr/issues/50#issuecomment-69627992

andreasstieger commented 9 years ago

I think the more strict 4.1.x in 4ad3b7b6c85be0154ab3694fe9831796db20c4fe is wrong or at least incomplete. libotr >= 4.0.0 is sufficient and matches configure.ac?

dgoulet commented 9 years ago

On 12 Jan (11:41:06), Andreas Stieger wrote:

I think the more strict 4.1.x in 4ad3b7b6c85be0154ab3694fe9831796db20c4fe is wrong or at least incomplete. libotr >= 4.0.0 is sufficient and matches configure.ac?

4.1.0 has a critical fix for irssi-otr which before distros had to pull it manually in their package.

So, I would really advocate for 4.1.x here because of that.


Reply to this email directly or view it on GitHub: https://github.com/cryptodotis/irssi-otr/issues/50#issuecomment-69631779

andreasstieger commented 9 years ago

As a distribution package maintainer I am aware of that, but would recommend the above for completeness.