search

cryptoeax / arbbot

Arbitrator, a bitcoin/altcoin arbitrage trading bot
https://gitter.im/cryptoeax-arbbot/Lobby
GNU General Public License v3.0
198 stars 78 forks source link

Added docker-compose.yaml file #100

Closed sigismund closed 6 years ago

sigismund commented 6 years ago

Option to run bot in docker, which can be good in terms of security, because services are isolated and all config files can be pre-set. It also makes it pretty easy to test the bot out, without the need of settings up the VPS.

cryptoeax commented 6 years ago

I uploaded my version of this effort to #113. As you can see I have pulled in quite a bit of your code in this PR there, thanks a lot! If you are familiar with Docker I appreciate if you can take a look at my branch please, the web interface isn't being loaded on localhost when I run docker-compose up right now and I can't figure out why... Thanks!

sigismund commented 6 years ago

I noticed yea, I thought you already had some dockerization finished before... ;) Anyway I fixed the configs files and started a pull request. Did you do any bot benchmark comparison between HHMV and PHP7? In a lot of cases PHP7 can be faster than HHVM and it has lower memory footprint. A lot of people are running this bot on instances with low memory, so I think this should be considered.

cryptoeax commented 6 years ago

Good point. I'm planning to add a configuration option to allow people to run php7 to run the bot. I suspect the answer is different depending on the host machine.

Since I've merged the parts of this PR which were useful, I'm going to close it now. Thanks a lot!