cryptoeax / arbbot

Arbitrator, a bitcoin/altcoin arbitrage trading bot
https://gitter.im/cryptoeax-arbbot/Lobby
GNU General Public License v3.0
200 stars 78 forks source link

Get rid of warnings when coin is blocked and its desired balance gets calculated #132

Open andygoossens opened 6 years ago

andygoossens commented 6 years ago

I have some units of a coin that I don't want to trade, so I have blocked that coin in the configuration.

However, the bot still notices the coin when it queries all the balances. Since that information is stored in $wallets, that information can be retrieved by calling getWallets() or getWalletsConsideringPendingDeposits(). So far, everything is still OK.

At some point saveSnapshot() gets executed. It will iterate over all the wallets, even the one of the blocked coin. And then:

We should avoid these messages and just decide that the $desiredBalance value of a blocked coin is equal to its current balance.

cryptoeax commented 6 years ago

Sure, I'd be open to removing any warning messages that are spammy and/or don't make sense. Do you feel like creating a PR for these? :-)