search

cryptoeax / arbbot

Arbitrator, a bitcoin/altcoin arbitrage trading bot
https://gitter.im/cryptoeax-arbbot/Lobby
GNU General Public License v3.0
200 stars 78 forks source link

Update the UI (wallets and charts) taking in-flight deposits into account again #139

Open jjc6676 opened 6 years ago

jjc6676 commented 6 years ago

Testing Binance exhange.

I have asked the bot to liquidate the current assets at the exchange, and that was successful. However, after the liquidation, the bot/web ui, does not report back the correct amount of BTC. At least not right away before a manage-run.

The exchange has more BTC from the liquidation than is being reported.

cryptoeax commented 6 years ago

This is an implication of the fix to #50 I believe. At some point in the past I changed the web UI to report the live balance of an exchange taking any pending transfers into account, but that code was slow so I removed it for now, so the UI for now shows your balances as of the last manage cycle, indicated by the wallet age displayed in minutes in the UI.

At some point I may bring back the live view with a faster implementation now that we can do it in a better way.

Note that you are mentioning "I have asked the bot to liquidate the current assets at the exchange." I'm not exactly sure what you mean by this, but note that the bot right now watches the changes in the balances in your exchange wallets very closely as a result of the trades that it makes, and if you have modified the bot's code to make it sell assets, it's very likely that you may have introduced a bug that affects the bot's notion of pending deposits and balances... :-)

jjc6676 commented 6 years ago

Let me be more clear what I mean by

I have asked the bot to liquidate the current assets at the exchange.

I owned coins on Binance before introducing the bot to the exhange. I also have auto-liquidation set to true for unneeded coins.

Since the coin I have is not traded on any other exhange, substratum, I was expecting the bot to liquidate it and convert to BTC, which I am ok with.

Anyways, I will test this again.

Thank you for clarifying that the code was slow. I am always up for optimizing!

cryptoeax commented 6 years ago

Let me be more clear what I mean by

I have asked the bot to liquidate the current assets at the exchange.

I owned coins on Binance before introducing the bot to the exhange. I also have auto-liquidation set to true for unneeded coins.

Since the coin I have is not traded on any other exhange, substratum, I was expecting the bot to liquidate it and convert to BTC, which I am ok with.

Yep, that should be how things work.

Anyways, I will test this again.

Thank you for clarifying that the code was slow. I am always up for optimizing!

NP. I will fix this at some point, it was just lower priority and I wanted to make the real improvements that the code I removed was standing in the way of. :-) But this doesn't have any impact on how the bot works, it's purely a UI presentation issue, FWIW.

I'm going to reopen your issue and edit it and make it about updating the UI in real time.