search

cryptoeax / arbbot

Arbitrator, a bitcoin/altcoin arbitrage trading bot
https://gitter.im/cryptoeax-arbbot/Lobby
GNU General Public License v3.0
199 stars 78 forks source link

Fix suspicious condition in Arbitrator.php #64

Closed cryptoeax closed 6 years ago

cryptoeax commented 6 years ago

See https://github.com/cryptoeax/arbbot/blob/51bbb83f1a1c90e87c2c8eca9f45efabc44ec1ca/bot/Arbitrator.php#L221

abs( $targetPrice - $sourcePrice ) > 0.00000002 is a tautology.

cryptoeax commented 6 years ago

Also note the definition of $sourcePrice is also wrong...

cryptoeax commented 6 years ago

I removed this code in a7f0bbafd9c8e5112b665fd73f1e3c3ae433dad7.