search

cryptofuture / nginx-hda-bundle

Nginx HDA Bundle - Dynamic Modules Power
https://launchpad.net/~hda-me/+archive/ubuntu/nginx-stable
81 stars 11 forks source link

Nginx brotli update #16

Closed btd closed 6 years ago

btd commented 6 years ago

Hi there.

First of all thank you for your awesome work.

May i suggest to switch ngx_brotli location from google/ngx_brotli which is not supported anymore. To switch to fork from one of libbrotli maintainers https://github.com/eustas/ngx_brotli (also google guy)?

cryptofuture commented 6 years ago

Nice. Looks like to the date brotli, I'll try to update bundle along with it and nginx 1.13.8 soon. I trying to switch/update submodules only if I'm 100% sure I'll be able to build it, this also ensures anyone else could build successfully using the same tag/commit number.

btd commented 6 years ago

Awesome thank you.

cryptofuture commented 6 years ago

Closed with fbd36660c77b98c155a773b37ff0eb09d90bd9ef

cryptofuture commented 6 years ago

@btd #18 Did you tested brotli filter module with last update?

btd commented 6 years ago

not yet (i noticed launchpad build servers not working for some time)

btd commented 6 years ago

I just noticed another issue with it, i will try to test it today also.