cryptography-cafe / curve25519-elisabeth

Pure Java implementation of group operations on ristretto255 and Curve25519
Other
26 stars 9 forks source link

Scalar arithmetic #13

Closed str4d closed 5 years ago

str4d commented 5 years ago

Includes 29-bit arithmetic ported from curve25519-dalek, which we use for addition, subtraction, and decoding / reduction.

Multiplication and multiply-and-add use the existing arithmetic extracted from ed25519-java, as it is over twice as fast.

codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into master will increase coverage by 0.05%. The diff coverage is 96.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
+ Coverage     96.34%   96.39%   +0.05%     
- Complexity      138      164      +26     
============================================
  Files            11       12       +1     
  Lines          1367     1527     +160     
  Branches         66       73       +7     
============================================
+ Hits           1317     1472     +155     
- Misses           34       36       +2     
- Partials         16       19       +3
Impacted Files Coverage Δ Complexity Δ
...n/java/cafe/cryptography/curve25519/Constants.java 88.88% <100%> (+5.55%) 1 <0> (ø) :arrow_down:
...main/java/cafe/cryptography/curve25519/Scalar.java 98.58% <87.5%> (-0.17%) 33 <10> (+11)
...a/cafe/cryptography/curve25519/UnpackedScalar.java 97.16% <97.16%> (ø) 15 <15> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83a3943...bbb5245. Read the comment docs.