search

cryptoloutre / solana-tools

A bunch of tools to help people in the Solana ecosystem. This website includes an UI to burn Solana NFTs and an UI to create SPL-Tokens. More tools are scheduled...
https://solanatools.vercel.app/
Apache License 2.0
145 stars 85 forks source link

Issue on burning NFTs in devnet #6

Closed irzinfante closed 1 year ago

irzinfante commented 1 year ago

Hello, I'm facing some issues when trying to use the most recent code of the repository for burning NFTs in devnet.

When I use the solana-tools page for devnet (https://solanatools-devnet.vercel.app/gallery) for burning NFTs everything works fine, and the instructions in the transaction for burning the NFT are like these: image

However, when trying to do the same thing with a local instance (http://localhost:3001/burnNFT) of the solana-tool (doing the instalation following the README.md and choosing the endpoint for devnet in the _app.tsx file) I can't burn the NFTs and the instructions of the transaction are these ones: image

I have also notice that at some point the name of the page for burning NFTs was changed: https://github.com/cryptoloutre/solana-tools/commit/d663760892c61db4a0d9ccf370f876aef0924e76. And it looks like the page in https://solanatools-devnet.vercel.app/ uses the old name, so I guess that the version of the code deployed there may not be the most recent code of the repository.

Could any clarification regarding all these things be given please? The code running in https://solanatools-devnet.vercel.app/ is working, and I would like to know which commit was it.

Many thanks in advance, Iker

cryptoloutre commented 1 year ago

Hi @irzinfante :) The source code of https://solanatools-devnet.vercel.app/ can be found here. When I built SolanaTools, I didn't know how to make the switch mainnet<>devnet so I created a repo for both. The repo for the devnet is outdated that's why the name of the page doesn't match. I am aware of this issue for a few days and I will fix it ASAP. The issue comes from the burn function of the BurnNFTView/index.tsx file. The problem is that no instruction is added to the transaction. So I guess I broke something in the condition during a recent modification.

irzinfante commented 1 year ago

Understood. Thank you for your help and clarifications. :+1:

From my side this issue can be closed. But if you want you can keep it, as a reminder, until you have fix the error.

cryptoloutre commented 1 year ago

You're welcome. I keep it and I will ping you once fixed ;)

In any case, sorry for the inconvenience

irzinfante commented 1 year ago

Hello @cryptoloutre. Take a look at PR #7 please. This worked for me and it may solve the issue.

cryptoloutre commented 1 year ago

@irzinfante merged! Thanks a lot and sorry for the inconvenience :/