search

cryptomator / android

Cryptomator for Android
https://cryptomator.org
GNU General Public License v3.0
744 stars 123 forks source link

Cryptomator is blocked when obscured but doesn't show a hint while entering the license #319

Closed SailReal closed 3 years ago

SailReal commented 3 years ago

Description

See title

System Setup

Steps to Reproduce

  1. Install and enable an app that draws over others like Twilight
  2. Install Cryptomator from F-Droid, Website or Github
  3. Start Cryptomator

Expected Behavior

App is obscured dialog is shown:

Actual Behavior

Input is disabled but the obscured dialog isn't visible which leads to not having any idea why you can't enter the license:

Reproducibility

Always

Workaround

See this link on how to workaround it: https://docs.cryptomator.org/en/latest/android/settings/#block-app-when-obscured

SailReal commented 3 years ago

This is fixed in 68bb87c:

Note: see https://docs.cryptomator.org/en/latest/android/settings/#block-app-when-obscured what to do when you see the "App is obscured" dialog.

IMO this fix was necessary due a bug in Android DialogFragments that when filterTouchesWhenObscured is set to true in a DialogFragment, onFilterTouchEventForSecurity isn't called anymore. If this property is set in an Activity, the method is called as expected and handled accordingly. Hopefully this will get fixed so that we do not have to handle this differently in DialogFragments and Activities.