cryptomator / android

Cryptomator for Android
https://cryptomator.org
GNU General Public License v3.0
761 stars 127 forks source link

"Invalid SSL certificate" dialog should show SHA-256 fingerprint of the certificate when using WebDAV #490

Closed SailReal closed 1 year ago

SailReal commented 1 year ago

Please agree to the following

Summary

"Invalid SSL certificate" dialog should show SHA-256 fingerprint of the certificate instead of SHA-1

System Setup

- Android: X
- Cryptomator: 1.8.1

Cloud Type

WebDAV

Steps to Reproduce

  1. Setup self singed certificate WebDAV cloud, e.g. using https://hub.docker.com/r/twizzel/webdav
  2. Add this cloud location

Expected Behavior

"Invalid SSL certificate" dialog shows SHA-256 fingerprint of the certificate

Actual Behavior

"Invalid SSL certificate" dialog shows SHA-1 fingerprint of the certificate

Reproducibility

Always

Relevant Log Output

No response

Anything else?

https://github.com/cryptomator/android/blob/edc47c9914e5e6a1f600e2577594535f5be09591/data/src/main/java/org/cryptomator/data/util/X509CertificateHelper.kt#L35

It is not so dramatic because the entire certificate can be displayed in addition to the fingerprint as workaround.