Open JaniruTEC opened 1 year ago
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
The changes introduced in this pull request primarily involve updates to the method of accessing the cloud type across various classes in the org.cryptomator
package. The method type()
has been consistently replaced with getType()
, reflecting a shift from direct property access to using getter methods. This modification affects multiple classes, including DropboxCloud
, GoogleDriveCloud
, OnedriveCloud
, PCloud
, S3Cloud
, and WebDavCloud
, among others. Additionally, the Cloud
interface has been updated to declare type
as a property instead of a method, further aligning with this new access pattern.
In conjunction with these changes, several methods in repository factories and other components, such as CloudEntityMapper
, CloudRepositoryImpl
, and various use cases, have been updated to utilize the new getter method. The changes are largely syntactical, aimed at enhancing code clarity and consistency without altering the underlying logic or functionality of the affected classes. Furthermore, annotations like @NotNull
have been introduced in some methods to specify non-null return expectations, contributing to improved type safety across the codebase. Overall, the modifications focus on standardizing the access to cloud type information and improving the code's maintainability.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This PR turns
org.cryptomator.domain.Cloud#type()
from a nullable function into a non-nullable property. This allows for a simpler usage in Kotlin code and makes the code more idiomatic overall.