search

cryptomator / android

Cryptomator for Android
https://cryptomator.org
GNU General Public License v3.0
761 stars 127 forks source link

Update ImagePreviewFragment.kt #526

Open brownowski opened 8 months ago

brownowski commented 8 months ago

Fix banding in gradients by setting the preferred Bitmap config to Bitmap.Config.ARGB_8888 for SubsamplingScaleImageView

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The recent update introduces a minor yet significant enhancement to the ImagePreviewFragment within a Java application, focusing on image presentation. By specifying the bitmap configuration to ARGB_8888, the change aims to optimize the visual quality of images displayed to the user, ensuring richer color depth and better overall image clarity.

Changes

File Path Change Summary
.../presentation/ui/fragment/ImagePreviewFragment.kt Added a line to set the bitmap configuration to ARGB_8888 before image display.

🐰✨
In the realm of bits and bytes, a rabbit hopped tonight,
Tweaking colors, bright and true, in ARGB's splendid light.
With a hop, skip, and a leap, it set the pixels right,
Now every image, clear and deep, shines incredibly bright.
🌟🖼️

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
brownowski commented 8 months ago

Thanks for your contribution! 💚

Do you know if this is still a problem? davemorrissey/subsampling-scale-image-view#366

Hmm, it might be.

I've run some tests, and I found that Bitmap.Config.HARDWARE performed better on my tablet. I had a hard time noticing any performance issues with ARGB_8888 on my phone, and HARDWARE seemed to work well too.

On my tablet I did notice some stuttering when scrolling between larger images with ARGB_8888, or panning on a few select files. This went away with HARDWARE, and it still also resolved the banding issue.

It might be worth testing it out on more devices, but switching to Bitmap.Config.HARDWARE might be better than ARGB_8888.

SailReal commented 7 months ago

Just to keep you up to date: I have done some more research and think this change needs more testing, but Bitmap.Config.HARDWARE sounds like the way to go to me.

SailReal commented 7 months ago

This will also fix https://github.com/cryptomator/android/issues/482