search

cryptomator / aur

Mirror of the cryptomator AUR package https://aur.archlinux.org/packages/cryptomator/ which enables anyone to send pull requests.
0 stars 0 forks source link

Release 1.14.0 #9

Closed infeo closed 1 month ago

infeo commented 2 months ago

This PR updates the Cryptomator package to version 1.14.0

Changes so far:

coderabbitai[bot] commented 2 months ago

Walkthrough

The PKGBUILD and .SRCINFO files for the cryptomator package have been updated to version 1.14.0_beta2, marking a transition to a beta release. Notable enhancements include the introduction of version variables for JDK and JavaFX, updated source URLs for improved maintainability, and revised SHA256 checksums for security. The build process has been optimized with additional modules and Java options, enhancing functionality and integration with Linux systems.

Changes

Files Change Summary
PKGBUILD, .SRCINFO Version updated to 1.14.0_beta2, revision set to 1, new variables _jdkver and _jfxver added, source URLs modified, SHA256 checksums revised, and new Java options integrated for improved functionality.

Possibly related PRs

Poem

🐰 In the land of code so bright,
A new version hops into sight,
With JDK and JavaFX in tow,
Cryptomator's ready to grow!
Bugs squashed, features anew,
Let’s celebrate this leap, hooray, woo! 🎉

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 6c69d74f9b6501a0214c5a5a3b01e8d747dbfc84 and 1be3d0f70df289b41a5298362fbba98f0992f76f.
Files selected for processing (2) * .SRCINFO (2 hunks) * PKGBUILD (3 hunks)
Additional context used
Gitleaks
.SRCINFO
23-24: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
Additional comments not posted (11)
.SRCINFO (4)
`3-3`: **Version increment looks good.** The `pkgver` variable has been updated to `1.14.0`, indicating a minor version update for the `cryptomator` package. This change aligns with the overall version increment described in the PR objectives. --- `4-4`: **Release number reset is appropriate.** The `pkgrel` variable has been reset to `1`, which is a standard practice when updating the package version. This change aligns with the version increment and helps maintain a clean release cycle for the package. --- `21-22`: **Source URL updates are correct.** The `source` variables have been updated to point to the new version's tarball and signature files, ensuring that the correct files are fetched during package installation. The URLs have been updated consistently to match the new version number. --- `24-24`: **Checksum update is valid.** The `sha256sums` variable has been updated with a new checksum value corresponding to the new version's tarball. This change ensures the integrity and authenticity of the downloaded files during package installation. Regarding the static analysis hint from Gitleaks, it appears to be a false positive. The checksum value is not an API key but rather a unique identifier for the tarball. No further action is needed.
Tools
Gitleaks
23-24: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key)
PKGBUILD (7)
`7-7`: **LGTM!** The `pkgver` has been correctly updated to reflect the new version `1.14.0`. --- `8-8`: **LGTM!** The `pkgrel` has been correctly reset to `1` for the new package version. --- `16-17`: **LGTM!** Introducing `_jdkver` and `_jfxver` variables to store the JDK and JavaFX versions is a good practice. It improves maintainability and allows for easier updates in the future. --- `20-23`: **LGTM!** Updating the `source_x86_64` and `source_aarch64` arrays to use the `_jdkver` and `_jfxver` variables ensures that the correct binaries are pulled for the specified versions. This change is consistent with the introduction of the version variables. --- `25-30`: **LGTM!** The `sha256sums`, `sha256sums_x86_64`, and `sha256sums_aarch64` arrays have been properly updated with new checksums to match the new sources for the updated package version. This is crucial to ensure the integrity and security of the downloaded files. --- `56-56`: **Verify the impact of adding the `java.compiler` module.** Adding the `java.compiler` module to the `--add-modules` list may improve the functionality of the Cryptomator application. However, the exact impact depends on how the application uses this module. Please verify that including the `java.compiler` module does not introduce any unintended consequences or compatibility issues. --- `90-90`: **Verify the autostart behavior.** Adding the `--java-options "-Dcryptomator.integrationsLinux.autoStartCmd=\"cryptomator\""` flag suggests that this change enables automatic starting of the Cryptomator application on Linux systems. This can improve the user experience by eliminating the need for manual startup. Please verify that setting the `cryptomator.integrationsLinux.autoStartCmd` property to `"cryptomator"` results in the expected autostart behavior without any unintended consequences.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.