search

cryptomator / cryptofs

Java Filesystem Provider with integrated encryption
GNU Affero General Public License v3.0
94 stars 35 forks source link

Health check: Get affected fs nodes of result #150

Closed infeo closed 1 year ago

infeo commented 1 year ago

This PR adds the method getCausingCiphertextNodes() to the interface DiagnosticResult.

The method is intended to list ciphertext resources, which triggered the concrete result.

infeo commented 1 year ago

This "Feature" needs more thought.

The intention was to give the consumer the chance to see conflicting results (i.e. their fix would affect the same fs nodes). But the results are too loosley coupled.

For example, for path /d/AB/CDEFG/mumbJumbo.c9r exist two results A and B. The fix for A is to modify the attributes, for B is to move the node. Then you can first fix A and then B with success, but not first B and then A. This PR would only give the consumer the info, that there might be a conflict, but still outputs both results.

infeo commented 1 year ago

I openend https://github.com/cryptomator/cryptofs/issues/151 to discuss any possible solutions for fix resolving