Extend appdata.xml and align with AppStream specification

cryptomator / cryptomator-linux

Cryptomator .AppImage for Linux

GNU General Public License v3.0

14 stars 7 forks source link

Extend appdata.xml and align with AppStream specification #16

Closed dhet closed 4 years ago

dhet commented 4 years ago

This change is to extend the appdata.xml file and align it with the AppStream spec

Add launchable tag
The description tag only supports a small subset of HTML. For this I added a utility script which extracts a description from the cryptomator readme. Please note that the description generation is not (yet) automated
Add some categories
The .desktop file should be named like the application ID

CLAassistant commented 4 years ago

All committers have signed the CLA.

overheadhunter commented 4 years ago

Looks good so far. While we're discussing this: Shouldn't the file be named according to its ID? I.e. since we're saying <id>org.cryptomator.cryptomator</id>, it should be org.cryptomator.cryptoamtor.appdata.xml, right?

Will this PR close issue #4 as well?

overheadhunter commented 4 years ago

Also, to quote the spec, id should better be org.cryptomator.Cryptomator:

The ID must follow a reverse-DNS scheme, consisting of {tld}.{vendor}.{product}, for example org.kde.Gwenview or com.hugski.ColorHug2.

(note the camelcased product name)

dhet commented 4 years ago

Yes, you're right. I fixed the naming in d525325. This should solve the issue. Also, we should inform the last commenter that the app ID has changed.

overheadhunter commented 4 years ago

Thank you! ❤️