search

cryptomator / cryptomator-linux

Cryptomator .AppImage for Linux
GNU General Public License v3.0
14 stars 7 forks source link

Fix for https://github.com/cryptomator/cryptomator/issues/1169 #24

Closed purejava closed 4 years ago

purejava commented 4 years ago

Possible fix for https://github.com/cryptomator/cryptomator/issues/1169 Haven't built an AppImage yet.

overheadhunter commented 4 years ago

Before merging a "possible" fix, can you test the following?

  1. download cryptomator-1.5.3-x86_64.AppImage
  2. run cryptomator-1.5.3-x86_64.AppImage --appimage-extract
  3. run your patched jlink command (assuming you have JDK 14 in some test environment - note that there is a bug with jlink on Ubuntu's OpenJDK packages. Use AdoptOpenJDK instead.)
  4. replace the runtime in the extracted appimage with the one built by jlink
  5. test if the fix works
purejava commented 4 years ago

Thanks for the hints. After downloading buildkit-linux.zip, following the instructions in appimage.yml was no problem.

PR is fine:

[ralph@localhost Downloads]$ ./cryptomator--x86_64.AppImage 
09:26:43.324 [main] DEBUG org.cryptomator.common.Environment - java.library.path: /tmp/.mount_cryptocPPZZc/lib/app:/tmp/.mount_cryptocPPZZc/bin
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - user.language: de
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - user.region: null
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - logback.configurationFile: null
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - cryptomator.settingsPath: ~/.config/Cryptomator/settings.json:~/.Cryptomator/settings.json
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - cryptomator.ipcPortPath: ~/.config/Cryptomator/ipcPort.bin:~/.Cryptomator/ipcPort.bin
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - cryptomator.keychainPath: null
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - cryptomator.logDir: ~/.local/share/Cryptomator/logs
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - cryptomator.mountPointsDir: ~/.local/share/Cryptomator/mnt
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - cryptomator.minPwLength: null
09:26:43.326 [main] DEBUG org.cryptomator.common.Environment - cryptomator.buildNumber: appimage-1.5.3
09:26:43.353 [main] DEBUG org.cryptomator.common.ShutdownHook - Registered shutdown hook.
09:26:43.417 [main] DEBUG org.cryptomator.common.settings.SettingsProvider - Attempting to load settings from /home/ralph/.config/Cryptomator/settings.json
09:26:43.417 [main] DEBUG org.cryptomator.common.settings.SettingsProvider - Attempting to load settings from /home/ralph/.Cryptomator/settings.json
09:26:43.641 [main] INFO  org.cryptomator.launcher.Cryptomator - Starting Cryptomator 1.5.3 on Linux 5.6.6-300.fc32.x86_64 (amd64)
09:26:44.002 [JavaFX Application Thread] INFO  o.c.ui.launcher.FxApplicationStarter - JavaFX Runtime started.
overheadhunter commented 4 years ago

Allright, thank you! :)