cryptomator / cryptomator-linux

Cryptomator .AppImage for Linux
GNU General Public License v3.0
14 stars 7 forks source link

Appimage doesn't include update information #29

Closed Sugarcrisp-ui closed 3 years ago

Sugarcrisp-ui commented 3 years ago

I really like the cryptomator appimage that you provide. I would like to request that you include the update information with your appimage to allow users to take advantage of programs like appimageupdater to ensure the program is kept up to date

overheadhunter commented 3 years ago

To be more precise: The update information is included, but it is wrong. Running the appimage with --appimage-updateinformation yields:

bintray-zsync|cryptomator|cryptomator|cryptomator-linux|cryptomator-${BUILD_VERSION}-x86_64.AppImage.zsync
Sugarcrisp-ui commented 3 years ago

Hello Sebastian,

Based on your findings, you believe it should be working?

Brett

On Fri, Dec 11, 2020 at 4:52 PM Sebastian Stenzel notifications@github.com wrote:

To be more precise: The update information is included, but it is wrong. Running the appimage with --appimage-updateinformation yields:

bintray-zsync|cryptomator|cryptomator|cryptomator-linux|cryptomator-${BUILD_VERSION}-x86_64.AppImage.zsync

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cryptomator/cryptomator-linux/issues/29#issuecomment-743094053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP5Q2SZ675KSCJSO4LIL5RTSUHTUJANCNFSM4UUW5HJQ .

Sugarcrisp-ui commented 3 years ago

Hey Sebastian,

I was following up with Cryptomator and one other software from a different vendor. I re-read your email and realized that it is working and responded to the wrong one. Thanks for the follow up and for packaging a great software.

Brett

On Fri, Dec 11, 2020 at 4:52 PM Sebastian Stenzel notifications@github.com wrote:

To be more precise: The update information is included, but it is wrong. Running the appimage with --appimage-updateinformation yields:

bintray-zsync|cryptomator|cryptomator|cryptomator-linux|cryptomator-${BUILD_VERSION}-x86_64.AppImage.zsync

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cryptomator/cryptomator-linux/issues/29#issuecomment-743094053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP5Q2SZ675KSCJSO4LIL5RTSUHTUJANCNFSM4UUW5HJQ .

overheadhunter commented 3 years ago

${BUILD_VERSION} is wrong, as explained here:

Path where the zsync file is stored on Bintray (MUST NOT change from version to version). Note the use of the Bintray feature _latestVersion to facilitate this

Therefore we should change this as follows:

- ./tools/appimagekit/squashfs-root/AppRun Cryptomator.AppDir cryptomator-${BUILD_VERSION}-x86_64.AppImage -u "bintray-zsync|cryptomator|cryptomator|cryptomator-linux|cryptomator-${BUILD_VERSION}-x86_64.AppImage.zsync"
+ ./tools/appimagekit/squashfs-root/AppRun Cryptomator.AppDir cryptomator-${BUILD_VERSION}-x86_64.AppImage -u 'bintray-zsync|cryptomator|cryptomator|cryptomator-linux|cryptomator-_latestVersion-x86_64.AppImage.zsync'