cryptomator / cryptomator-linux

Cryptomator .AppImage for Linux
GNU General Public License v3.0
14 stars 7 forks source link

Switching to JavaFX 11: Wayland support needs additional flag #9

Closed infeo closed 5 years ago

infeo commented 5 years ago

When we finally switch to JavaFX 11, we should be aware of the bug JavaFX exposes on linux systems using Wayland as display server (see https://github.com/javafxports/openjdk-jfx/blob/jfx-11/doc-files/release-notes-11.md#javafx-crashes-with-openjdk-11-on-ubuntu-1804-with-wayland).

As a workaround we should either detect before cryptomator is starting which display server is used (e.g. by a startupscript) or should use always the announced workaround with java -Djdk.gtk.version=2 ....

infeo commented 5 years ago

According to this post we can query the environment variable XDG_SESSION_TYPE and check if it equals 'wayland' or not

overheadhunter commented 5 years ago

According to JDK-8210411 this will be fixed with OpenJFX 12.

overheadhunter commented 5 years ago

Backported to OpenJFX 11.0.2 (JDK-8216292), therefore resolved.

overheadhunter commented 5 years ago

Reopening as the upstream fix doesn't work (see https://github.com/cryptomator/cryptomator/issues/846#issuecomment-475979998). We have to use GTK 2.

overheadhunter commented 4 years ago

Seems like we can't satisfy every user. For now we will include the flag again.

Users who need the flag:

Users who need to remove the flag: