cryptomator / cryptomator-win

Cryptomator .exe installer for Windows
GNU General Public License v3.0
21 stars 12 forks source link

Dokany silent install possible (Chocolatey)? #11

Closed RiseT closed 5 years ago

RiseT commented 5 years ago

Basic Info

I'm using Windows / macOS / Linux / … in version: Win 10

I'm running Cryptomator in version: 1.4

Description

It seems like Dokany currently bypasses the silent install args during installation which leads to failed automated testing of the Chocolatey package:

https://chocolatey.org/packages/cryptomator/1.4.0 (Note the failed automated testing and the comment by the package maintainer in the comment section)

Is there something that can be done about this on your side?

Attachments (optional)

n/a

overheadhunter commented 5 years ago

I don't know chocolatey in detail, but does it support dependencies? If so, the Cryptomator package could simply add a dependency to Dokany. If Dokany is already installed, the Cryptomator installer will not invoke any sub-installer.

RiseT commented 5 years ago

I'm no chocolatey expert either, but I do know for a fact that it does support dependencies.

overheadhunter commented 5 years ago

Then this should be the easiest and most reliable solution. 🙂

Edit: Also it allows chocolatey users to uninstall Dokany the same way it got onto the system. Therefore I consider it more transparent than any implicitly invoked sub-installer.

RiseT commented 5 years ago

Thanks! So I'm closing this for the time being. I've pointed the package maintainer to this thread.

RiseT commented 5 years ago

@overheadhunter The dependency been implemented into the chocolatey package now.

I wonder, though, what the difference between

For both there are choco packages available:

And which one is more appropriate regarding a dependeny for Cryptomator?

overheadhunter commented 5 years ago

The msi package only installs Dokan itself, while the redist installer also includes Visual C++ Redistributable for both, x86 and x64.

Since we're already using Chocolatey for dependency management, I'd suggest to use the smaller msi package.

Btw I think the Dokany package should update its dependencies, too:

@Liryna is this assumption correct?

Liryna commented 5 years ago

Hi @overheadhunter ,

You are exactly right. The installer no longer needs dotnet and vcredist used is 2017 👍

bcurran3 commented 5 years ago

Hi @Liryna,

I've updated the Chocolatey package for the next release. I've removed the dotnet4.0 dependency and changed the vcredist2015 dependency to vcredist2017.

Is kb2999226 still required?

Liryna commented 5 years ago

kb2999226 is still required unfortunately yes. We tried to remove it when moving for vc2017 but found out that still needed for vc2017 install 😢 https://github.com/dokan-dev/dokany/issues/628

bcurran3 commented 5 years ago

Thanks for the verification. I'll keep it in.

Hariama commented 5 years ago

Hi all,

@RiseT: Thank you for notifying me for the update, and for working out with @overheadhunter that adding the dependency was the right move. As the .msi file is much smaller, I'll keep the dependency as-is right now. Sorry that it took so long to update, I tried to make it work within the automated verification process, but with the dokany-dependency this was no longer possible.

bcurran3 commented 5 years ago

...but with the dokany-dependency this was no longer possible.

Actually because of the kb2999226 dependency. :)