search

cryptomator / cryptomator-win

Cryptomator .exe installer for Windows
GNU General Public License v3.0
21 stars 12 forks source link

Cryptomator setup changes FileSizeLimitInBytes even if WebDAV is unchecked #22

Closed hippotastic closed 4 years ago

hippotastic commented 4 years ago

Description

When installing Cryptomator on Windows and unchecking WebDAV support, setup still changes the HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\WebClient\Parameters value FileSizeLimitInBytes to MAX_DWORD (0xffffffff).

This is supposed to be a fix for working with files above 50 MB over WebDAV (50 MB is the default value for this limit) and only needed when using WebDAV.

If I do not want to use WebDAV and therefore uncheck it during setup, Cryptomator should not touch WebDAV-related registry settings.

System Setup

Steps to Reproduce

  1. Launch the installer
  2. Uncheck WebDAV
  3. Finish the installation
  4. Open regedit
  5. Navigate to HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\WebClient\Parameters
  6. Check the value of FileSizeLimitInBytes

Expected Behavior

The FileSizeLimitInBytes should still have the Windows default value of 50000000 (0x2faf080).

Actual Behavior

The FileSizeLimitInBytes is changed to MAX_DWORD (0xffffffff).

Reproducibility

Always

overheadhunter commented 4 years ago

Adding Components: webdav to this line should fix it:

https://github.com/cryptomator/cryptomator-win/blob/9067840e5f7e66cdb13112c4ef419bb8abcd7b4b/resources/innosetup/setup.iss#L53