search

cryptomator / cryptomator

Multi-platform transparent client-side encryption of your files in the cloud
https://cryptomator.org
GNU General Public License v3.0
11.63k stars 1.01k forks source link

Unable to Permanently Remove Supporter Certificate #3475

Open mindmonk opened 3 months ago

mindmonk commented 3 months ago

Please agree to the following

Summary

Under Preferences -> Support Us, it is not possible to permanently remove an existing supporter certificate. Although the certificate can be deleted from the text field, it reappears upon restarting the app, indicating that the change is not being saved in the settings.

What software is involved?

Volume Type

None

Steps to Reproduce

  1. Navigate to Preferences -> Support Us.
  2. Delete the existing supporter certificate from the text field.
  3. Close and restart the app.
  4. Go back to Preferences -> Support Us and observe that the previously deleted certificate has reappeared.

Expected Behavior

The supporter certificate should be permanently removed and the change should be saved in the settings, so that it does not reappear after restarting the app.

Actual Behavior

The deleted supporter certificate reappears upon restarting the app, indicating that the change is not saved in the settings.

Reproducibility

Always

Relevant Log Output

No response

Anything else?

No response

tobihagemann commented 3 months ago

To be honest, I don't think that we should solve this by allowing the supporter certificate to be deleted. That doesn't make a lot of sense for regular users. I guess, this "bug" is only noticeable for developers. :wink:

I'd even go that far and suggest removing the text area completely, so that you can't edit the supporter certificate, once it has been validated and saved successfully. There is really no need to change it. Instead, we could add a simple "thank you" note.

overheadhunter commented 2 months ago

I'd even go that far and suggest removing the text area completely, so that you can't edit the supporter certificate, once it has been validated and saved successfully. There is really no need to change it. Instead, we could add a simple "thank you" note.

It happened more than once that users wanted to update the email address that is associated with the cert. If we removed the textarea, users wouldn't be able to replace one cert with another.

tobihagemann commented 2 months ago

All right, then this issue remains valid and there should be a way to remove (or replace?) the supporter certificate. I'd still like to remove the text area though and replace it with something more cheerful, but I guess @mindmonk is already working on that.