search

cryptomator / fuse-nio-adapter

FUSE-based adapter to provide directory contents specified by a java.nio.file.Path
GNU Affero General Public License v3.0
24 stars 14 forks source link

Feature: JDK 22 #122

Closed infeo closed 7 months ago

infeo commented 7 months ago

This PR updates the project to JDK 22.

Included changes:

Summary by CodeRabbit

coderabbitai[bot] commented 7 months ago

Walkthrough

The project has been updated to JDK 22, involving changes in GitHub Actions workflows, IntelliJ IDEA configurations, Maven settings, and source code. The --enable-preview flag has been removed, and unused variables in method parameters have been replaced with _ to improve code readability.

Changes

Files Change Summary
.github/workflows/... Updated Java version from 21 to 22 in GitHub Actions workflows.
.idea/misc.xml Updated Java language level from JDK_21 to JDK_22.
.idea/runConfigurations/Mirror.xml Removed --enable-preview flag from VM parameters.
pom.xml Updated JDK version to 22, updated jfuse to 0.7.0, removed --enable-preview.
src/main/java/org/cryptomator/frontend/fuse/...Adapter.java Replaced dataLock with _ in method parameters.

Possibly related issues

Poem

🎉🐇 To JDK 22 we hop,
No more --enable-preview, let it drop.
With _ in place, the code now neat,
Cryptomator's updates are quite a feat.
Cheers to the devs, hip hip hooray,
Onward we code, by night and by day!
🎉🐇

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 6d00e55292a4f43724d4be5041dc6829e1025f45 and 843cb154ce14e2b6390e162467d3929afa1d9983.
Files selected for processing (10) * .github/workflows/build.yml (1 hunks) * .github/workflows/codeql-analysis.yml (1 hunks) * .github/workflows/dependency-check.yml (1 hunks) * .github/workflows/publish-central.yml (1 hunks) * .github/workflows/publish-github.yml (1 hunks) * .idea/misc.xml (1 hunks) * .idea/runConfigurations/Mirror.xml (1 hunks) * pom.xml (3 hunks) * src/main/java/org/cryptomator/frontend/fuse/ReadOnlyAdapter.java (8 hunks) * src/main/java/org/cryptomator/frontend/fuse/ReadWriteAdapter.java (11 hunks)
Files skipped from review due to trivial changes (4) * .github/workflows/build.yml * .idea/misc.xml * src/main/java/org/cryptomator/frontend/fuse/ReadOnlyAdapter.java * src/main/java/org/cryptomator/frontend/fuse/ReadWriteAdapter.java
Additional comments not posted (7)
.github/workflows/dependency-check.yml (1)
`17-17`: Update to JDK 22 is correctly applied in the dependency check workflow.
.idea/runConfigurations/Mirror.xml (1)
`5-5`: Correct removal of `--enable-preview` and appropriate use of `--enable-native-access=ALL-UNNAMED` in the IntelliJ IDEA run configuration.
.github/workflows/codeql-analysis.yml (1)
`23-23`: Update to JDK 22 is correctly applied in the CodeQL analysis workflow.
.github/workflows/publish-github.yml (1)
`13-13`: Update to JDK 22 is correctly applied in the GitHub Packages publishing workflow.
.github/workflows/publish-central.yml (1)
`18-18`: Update to JDK 22 is correctly applied in the Maven Central publishing workflow.
pom.xml (2)
`20-20`: Update to JDK 22 is correctly applied in the Maven POM file. --- `24-24`: Update to `jfuse` version 0.7.0 is correctly applied in the Maven POM file.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud