cryptomator / fuse-nio-adapter

FUSE-based adapter to provide directory contents specified by a java.nio.file.Path
GNU Affero General Public License v3.0
24 stars 14 forks source link

Enable xattr for Winfsp #87

Open infeo opened 7 months ago

infeo commented 7 months ago

Due to #86, we had to deactivate extended attributes for Windows. It is desirable to activate again, but it depends on https://github.com/winfsp/winfsp/issues/531.

infeo commented 7 months ago

We could do a similar approach as for getxattr: https://github.com/cryptomator/fuse-nio-adapter/blob/4dbe69392575d00e96c3d27d7f9378a5abffbd49/src/main/java/org/cryptomator/frontend/fuse/ReadOnlyAdapter.java#L242-L247

infeo commented 7 months ago

A different approach: Precheck the underlying filesystem for userdefined attribute view via [FilesystemProvider::supportedAttributeViews](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/FileSystem.html#supportedFileAttributeViews()) and adjust the set of supported operations accordingly!

We would loose flexibility, if the underlying filesystem suddenly activates the userDefinedAttributeView.