Closed tobihagemann closed 1 year ago
Now I'm wondering about UpdateVaultMembershipEvent
(with its operation
column for ADD
and REMOVE
) vs. RegisterDeviceEvent
+ RemoveDeviceEvent
.
Should we split up UpdateVaultMembershipEvent
as well? E.g., to AddVaultMembershipEvent
and RemoveVaultMembershipEvent
?
@infeo I've split up UpdateVaultMembership
into their own add and remove events after discussing this with @overheadhunter.
At first, my goal was to update the
CreateVaultEvent
with name/description and add a newUpdateVaultEvent
.But during testing, I felt that the audit log still felt incomplete. That's why I also added
GrantVaultAccessEvent
,RegisterDeviceEvent
, andRemoveDeviceEvent
.