cryptomator / hub

Cryptomator Hub helps you manage vaults in large teams
GNU Affero General Public License v3.0
41 stars 9 forks source link

Update Audit Events #213

Closed tobihagemann closed 1 year ago

tobihagemann commented 1 year ago

At first, my goal was to update the CreateVaultEvent with name/description and add a new UpdateVaultEvent.

But during testing, I felt that the audit log still felt incomplete. That's why I also added GrantVaultAccessEvent, RegisterDeviceEvent, and RemoveDeviceEvent.

Screenshot 2023-07-18 at 16 49 41
tobihagemann commented 1 year ago

Now I'm wondering about UpdateVaultMembershipEvent (with its operation column for ADD and REMOVE) vs. RegisterDeviceEvent + RemoveDeviceEvent.

Should we split up UpdateVaultMembershipEvent as well? E.g., to AddVaultMembershipEvent and RemoveVaultMembershipEvent?

tobihagemann commented 1 year ago

@infeo I've split up UpdateVaultMembership into their own add and remove events after discussing this with @overheadhunter.