cryptomator / hub

Cryptomator Hub helps you manage vaults in large teams
GNU Affero General Public License v3.0
36 stars 8 forks source link

On License exceedance vault creation possible #262

Closed infeo closed 2 months ago

infeo commented 4 months ago

Please agree to the following

Summary

If the license is exceeded, it should not be possible to create a vault. Still the create vault flow can be started, but stops with an error. If the user returns to the vault list, the vault is created anyway.s

System Setup

- Hub: 1.3.3
- Keycloak: -

Steps to Reproduce

  1. Ensure that license is exceeded (e.g. add group to a vault and increase group size afterwards with new members)
  2. log in as a user or admin
  3. Start create vault flow

Expected Behavior

Cannot start vault creation, because license is exceeded.

Actual Behavior

Can continue vault creation till display of recovery key: grafik

Returing to the vault list, the vault unexpectedly exists: grafik

Reproducibility

Always

Relevant Log Output

No response

Anything else?

No response

infeo commented 4 months ago

The still-created-vault is an API problem of our backend. We have to revise the conditions introduced in #258.