Closed infeo closed 5 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository.To trigger a single review, invoke the
@coderabbitai review
command.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Can we make the entities' fields private? Or what is the rationale of making them just package-private?
I changed this in da069504dd3c1c2d7e51b6bb0c58194a44d400df . Honestly, at the time of doing the migration, i was just lazy 😓
Shouldn't we at least for the *Event type entities try to use a single repository...
I didn't combined in a single repository, but changed the code such that all calls are bundled in a single class EventLogger
.
This PR contains the migration from the panache active record to the repository pattern.
Reasons for this migration:
Regarding the implemenation, no entitiy extends the PanacheEntityBase anymore, but are plain POJOs with Jakarta persistence annotations. The panache repositories are static subclasses of the enitites.
Additional changes: