cryptomator / integrations-api

API for optional services, such as system keychain integrations
GNU Affero General Public License v3.0
12 stars 4 forks source link

Feature: Filemanager Sidebar Integration SPI #35

Closed infeo closed 5 months ago

infeo commented 5 months ago

This is a proposal for an new SPI: The Sidebar SPI.

This spi is intended to allow an application to add an entry to the filemanager sidebar/navigation pane/bookmark section/etc, such that a user can easily access a certain path (e.g. mounted vault).

The SPI is kept simple: Only a single service, namely the SidebarService offering a single function add(target, displayName) to add an entry to the filemanager sidebar. The function returns an object (SidebarEntry), which is used to remove the entry again. The methods throw an service specific SidebarServiceException.

coderabbitai[bot] commented 5 months ago

Walkthrough

The overall change introduces a new SidebarService interface to handle sidebar integrations, modifies the module-info.java to include this new service, and updates the version in pom.xml to reflect these changes. New methods and an exception class streamline the addition and removal of sidebar entries, enhancing the sidebar feature integration.

Changes

Files Change Summary
pom.xml Updated version from 1.4.0-SNAPSHOT to 1.4.0-sidebar.
src/main/java/module-info.java Added import for SidebarService, exported the new package, and declared usage of SidebarService.
src/main/java/org/cryptomator/integrations/sidebar/... Introduced SidebarService interface, methods for sidebar entry management, and the new exception class SidebarServiceException.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant SidebarService
    participant FileManager

    Client->>SidebarService: add(target, displayName)
    SidebarService-->>FileManager: Integrate target into sidebar
    FileManager-->>SidebarService: Success/Error
    SidebarService-->>Client: SidebarEntry/Exception

    Client->>SidebarService: SidebarEntry.remove()
    SidebarService-->>FileManager: Remove entry from sidebar
    FileManager-->>SidebarService: Success/Error
    SidebarService-->>Client: Confirmation/Exception

Poem

From SNAPSHOT to sidebar, our code does grow,
With paths to the quick bar, new features to show.
Services to add, and entries to weave,
Through the file manager’s leaves, quick as a breeze.
🐰✨ Here’s to the journey of bytes well-spun,
A hop for the code, and progress begun! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
infeo commented 5 months ago

Superseded by https://github.com/cryptomator/integrations-api/pull/36