Remove Workaround code "catch RuntimeException | ExceptionInInitializerError "

cryptomator / integrations-linux

Linux-specific implemenations of the integrations-api

GNU Affero General Public License v3.0

11 stars 4 forks source link

Remove Workaround code "catch RuntimeException | ExceptionInInitializerError " #5

Closed infeo closed 3 years ago

infeo commented 3 years ago

With 3dfbc3f PR #4 was merged to prevent application crash on systems without a session DBus. But it is only a workaround, because either a very generic RuntimeException or an ExceptionInInitializeError is catched.

This code should be removed as soon as possible by updating upstream libraries.

infeo commented 3 years ago

A new version of dbus-java is out which would make this worarkound code obsolete. @swiesend , @purejava Can you check secret-service/kdewallet can be updatet to use the new release? Also PR #9 would benefit from this change.

purejava commented 3 years ago

kdewallet could be updated to dbus-java 3.3.0 without problems. kdewallet 1.2.1 depends on dbus-java 3.3.0 and is still backwards compatible for the Cryptomator implementation as the current keychain interface is not designed for async usage.