Fixed second purchase bug and added logo

[rossneilson]

Description

So this turned out to be quite a tricky one to debug and test. The initial issue was that after the first purchase, if more purchases were made without refreshing then they were not displayed in the bidlist. Essentially the issue was that events were triggering multiple events which resulted in none of them getting stored due to how the redux store was set up. Now the listener is only created once and so only one event gets listened to and dispatched to the state. I think I also fixed the problem for if multiple dispatches were created and so this certainly shouldn't happen again.

Also I added the new logos! yay We can still make changes if we want but I think they work well for the MVP.

Motivation and Context

Closes #452 Closes #453

How Has This Been Tested?

Lots of sales and purchases in rinkeby

Screenshots (if appropriate):

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[adamazad]

I think I have a fix for this. I’ll update this PR later tonight.

Sincerely,

Adam

On Thu 2. Sep 2021 at 9:51 AM Ross Neilson @.***> wrote:

@.**** commented on this pull request.

In src/hooks/useNewBidEventFromChain.ts https://github.com/cryptonative-ch/mesa-interface/pull/454#discussion_r700838372 :

   const commitment: GetAllBidsBySaleId_fixedPriceSale_commitments = {

• id: saleId + '/commitments/' + buyer + '/' + totalCommitmentsByUserAddress,
• id:
• saleId + '/commitments/' + buyer + '/' + String(await (await library.getBlock(event.blockNumber)).timestamp),

Perhaps I am missing something but I couldnt replicate this, can you on the preview deployment?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cryptonative-ch/mesa-interface/pull/454#discussion_r700838372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOWISCWTTRUICWY2DNAR2LT74UJJANCNFSM5DHI5W6A .

-- Adam Azad Skickat från mobil

[rossneilson]

I think I have a fix for this. I’ll update this PR later tonight. Sincerely, Adam

Sure, just bear in mind fixing this bug is the last small change we have before cutting release for MVP which we want to do this week as we prepare to slow down Aqua development