Feature/removing fairsale

cryptonative-ch / aqua-interface

🌐 Aqua dApp

https://aquadev.co

GNU Affero General Public License v3.0

11 stars 5 forks source link

Feature/removing fairsale #459

Closed rossneilson closed 3 years ago

rossneilson commented 3 years ago

Description

Removing fairsale for MVP 0.1.1 release Also removing contracts to use exported files from aqua-js, will add this to dev after also (I forgot in the previous PR) Updated xdai subgraph endpoint

Motivation and Context

Closes #445

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

mprasanjith commented 3 years ago

Two things we'll need to fix. I don't think these were introduced in this PR, but I'm leaving this comment here for visibility.

When you do a purchase, the order shows up fine, like below.

Let's keep this in mind, and go back to all sales. Notice that the sale card doesn't show any purchase data.

Now, let's refresh the page. The card now has my purchases shown nicely.

So first issue; We need to update the card to show the token purchases before refreshing the page. Just a minor tweak.

Now let's open the sale page again.

Screenshot 2021-09-08 at 19-11-14 Fixed Price Sale Token – FPST Aqua

Now the order history doesn't show up at all. That's the second issue.

I'll create separate issues for these for tracking.

PS: Issues created: #460 / #461

mprasanjith commented 3 years ago

Btw do we have any idea why the Netlify builds failed? I don't think we should care, but just in case.

rossneilson commented 3 years ago

Nice spotting those bugs, we'll get them fixed for MVP On netlify, I was thinking it was maybe because we are merging to main and not develop? But yeah, not important we could probably remove netlify

mprasanjith commented 3 years ago

Updated the PR to fix #461.

rossneilson commented 3 years ago

For some reason, not sure if this was just something we didn't test recently, sales that I participated in but failed to be successful sales were not appearing in the closed tab under my sales or other sales. To fix this I removed the filtering on successful sales for the claims section and turned the "Bids won" into "Participated sales". In future we should add different types of token claims here for failed and successful.

I will add this to dev branch also post merge here