cryptonetlab / retriev

Home of Retriev protocol (by CryptoNet + YOMI)
https://retriev.org
18 stars 5 forks source link

Add UI for registering as a provider #4

Closed 0xjona closed 2 years ago

turinglabsorg commented 2 years ago

@irenegia do we need to collect some data? or it will be just a web3 signin process at the moment?

turinglabsorg commented 2 years ago

@irenegia should this be done on-chain or off-chain? For example we should require an initial deposit to subscribe?

Also making a list of required fields needed to be inserted into signing page:

irenegia commented 2 years ago

@irenegia should this be done on-chain or off-chain? For example we should require an initial deposit to subscribe?

on-chain info

Also making a list of required fields needed to be inserted into signing page:

  • Miner ID
  • Filecoin address
  • E-Mail?

E-Mail may be optional?

@nicola anything else we should request for providers?

nicola commented 2 years ago

we only need miner id on-chain, all the other info don't need to be there.

irenegia commented 2 years ago

@Steve-Rog could you please upload a screenshot of the last version of the form?

The form right asks for

irenegia commented 2 years ago

Question: how is the sign up request sent? how is this collect?

What about someone that try to impersonate a provider (ie, bad guy subscribe an unaware provider to the protocol)? Is this possible/ is this a problem?

If yes, how can we avoid this? Ie, how do verify provider identity ?

nicola commented 2 years ago

folks we should not put emails on-chain and not even Filecoin addresses, this is an IPFS-based service

Steve-Rog commented 2 years ago

@irenegia Here is the screenshot of the form. I modified a few small details after yesterday's call, if there is anything else to modify I am at your disposal.

Image

turinglabsorg commented 2 years ago

folks we should not put emails on-chain and not even Filecoin addresses, this is an IPFS-based service

If it's not needed it's easier, there's nothing on-chain regarding the form. Only on-chain data is provider endpoint, which is needed to make p2p connections without relay to a centralized server. Any other data (e-mail, name etc) it's inside an off-chain storage.

@Steve-Rog remove the Filecoin address field please.

Steve-Rog commented 2 years ago

@turinglabsorg field removed

irenegia commented 2 years ago

okay, I had a clarifying discussion with Seb, I am writing the outcome here so everyone has context about what the alpha protocol does:

1) in our protocol providers and referees are connected via an ad-hoc p2p network, the "provider endpoint" requested in the sign up form is the address used to talk with the provider in this network (eg https://pippo.xyz);

2) IPFS is used:

3) we do not need any form of authentication in the sign up form: even if a guy provides the end point of another (unaware) provider, then the bad guy can not make the provider loose collaterals/tokens.

CC @nicola can you give me a 👍 / 👎 to this ?

Steve-Rog commented 2 years ago

The registration pages and API have been implemented and are online at the test site. I have also changed the text of the disclaimer as you indicated to me yesterday @irenegia.

If I need to change anything else, I am at your disposal. The task is currently completed

turinglabsorg commented 2 years ago

Closing because we decided to move the signup process to the CLI so the provider don't need to handle with user interfaces and share keys between node and browser. Adding a small video of the feature we built.

https://user-images.githubusercontent.com/14848252/183238468-8379c18e-3a92-4de0-8d10-ffe3bfd27963.mp4

.