cryptonomex / graphene-ui

Cryptonomex Graphene front end (wallet and decentralized exchange)
https://bitshares.openledger.info
MIT License
156 stars 100 forks source link

buy/sell does not calculate the price itself #776

Closed btswolf closed 8 years ago

btswolf commented 8 years ago

The buy/sell boxes do not work without a price input. But the price should be calculated based on the Amount and Total, instead it's deleting my last input when no price is given. image

abitmore commented 8 years ago

By now it works this way:

noisy commented 8 years ago

But the price should be calculated based on the Amount and Total, instead it's deleting my last input when no price is given.

Confirmed on version 2.0.160309

if no price is set, consider price = 0.

price set to 0 do not make much sense. There are always 3 fields: Price, Amount, Total. They are all connected because:

Price x Amount = Total

Whenever two of three values are provided, 3rd should be automatically calculated.

abitmore commented 8 years ago

The actual problem is: when you already have numbers in both price and amount, when you changed total, should the UI change price or amount automatically for you? Currently the UI always change amount but never change price.

A more detailed example: when price is empty, amount is 1, total is empty, you press the "1" key in total input box, you want the price change to "1"? OK, the new state is price=1, amount=1, total=1, you press the "1" key again, you want the price change to "11" or the amount change to "11"?

It's not a simple feature, if you want it be perfect, try to write a specification(detailed overall rules) first.

svk31 commented 8 years ago

Autofilling the price based on amounts and totals doesn't make much sense to me really, and I don't think any other exchanges currently do this. Polo at least does not.. It's a very unintuitive way of determining the price so I don't know if it's worth supporting it.

btswolf commented 8 years ago

I just tried to place an order and I did only know how much USD I have and how much BTS I want to get. I was not able to calculate the price in my own head so I thought the GUI should be able to do that for me. I thought it would be great to have, but I also see that it is not easy to implement and probably a not much needed feature.

svk31 commented 8 years ago

You still need to go by the current prices, so why not set a price around the current asking price, then click on your balance to enter the full amount (minus the fee if you're using that asset for the fee)?