cryptonomex / graphene

MIT License
1.05k stars 336 forks source link

New OP for issuer to reclaim fee pool funds #608

Closed xeroc closed 7 years ago

xeroc commented 8 years ago

Two points about the fee pool:

This should really exist as there is no real reason (AFAIK) that should prevent the issuer of an asset to also full control funds in the fee pool.

I propose a new claim_pool_balance_operation that takes

as arguments.

~I consider this high priority to get this included in the next hard fork (if by any means possible)~

abitmore commented 8 years ago

Assume the core exchange rate of the asset is 1 asset = 1 CORE, assume there is X CORE in fee pool, the issuer can claim funds from fee pool easily with following steps as a work around, no matter how much CORE is in the fee pool:

  1. issue X assets to herself
  2. craft an limit_order_create_operation which will never be filled, set the fee field to X assets, sign & broadcast it
  3. cancel the order

I believe @xeroc can make a python script to batch these operations, no need to write C++ code.

xeroc commented 8 years ago

@abitmore The approach you describe is exactly what I meant by "pool draining" in the OP. I see it as a hacky solution that cannot be used if you have your asset traded already.

abitmore commented 8 years ago

@xeroc what did you mean "have your asset traded already"? IMO the issuer can withdraw from fee pool with that approach at any time, anyone else can do that as well if have enough issued assets.

abitmore commented 8 years ago

The approach I provided is just not too "cumbersome and time consuming" as you said in OP.

vikramrajkumar commented 7 years ago

This issue was moved to bitshares/bitshares-core#188