cryptonomex / graphene

MIT License
1.05k stars 336 forks source link

Unable to propose a proposal with an `approve_proposal` operation #658

Closed abitmore closed 7 years ago

abitmore commented 8 years ago

Got this message while trying to propose a proposal with an approve_proposal operation:

10 assert_exception: Assert Exception
other.size() == 0:
    {}
    th_a  proposal_evaluator.cpp:54 do_evaluate

The issue is probably caused by lack of size checking on auth.key_auths before this line in proposal.cpp, imo the code could be

if( auth.key_auths.size() > 0 )
   o.emplace_back( std::move(auth) );

To fix this issue, a hard fork is needed.

abitmore commented 7 years ago

Actually it should be proposal_update_operation (and if to add an account authority to "approve" the proposal).

vikramrajkumar commented 7 years ago

This issue was moved to bitshares/bitshares-core#214