cryptonomex / graphene

MIT License
1.05k stars 337 forks source link

Check wallet.cpp calls to fc::ecc::blind_sum #673

Closed jcalfee closed 7 years ago

jcalfee commented 7 years ago

The second parameter to blind_sum is the number of non-negative factors. As coded the size of the vector is being passed instead:

fc::ecc::blind_sum( blinding_factors, blinding_factors.size() - 1 )
jcalfee commented 7 years ago

This is probably correct.. In the case above, it is marking all but the last blinding factor non-negative.