search

cryptosense / multipart-form-data

multipart/form-data (RFC2388) parser for OCaml
BSD 2-Clause "Simplified" License
19 stars 6 forks source link

Update to Dune syntax #22

Closed Leonidas-from-XIV closed 6 years ago

Leonidas-from-XIV commented 6 years ago

I am not exactly sure what the proper behaviour of the module should be. I would think the multipart module should be just moved to multipart_form_data and be the only exposed module. Thus it would avoid wrapping, and have a nice mapping from package-name to module name.

Leonidas-from-XIV commented 6 years ago

Thanks @NathanReb, good to know what your position is on this. It is a good point to add a Changelog entry. I was also thinking to maybe remove pkg/ altogether since dune-release does not need it anymore, so if you'd be willing to switch to that I can also remove it.

As an ex-Schemer and ex-Clojurist I find formatting lists this way strange, but it is your project so I also changed that 🙂

NathanReb commented 6 years ago

Sorry I was off for a couple weeks, I'll get back to this ASAP!

NathanReb commented 6 years ago

About removing pkg/, definitely in, maintaining META is a pain and I think dune-release fits perfectly for this project.

I you feel like removing it, be my guest, otherwise I can also do that later to get this merged.

Leonidas-from-XIV commented 6 years ago

I think it is better if you remove it, since I am on vacation now and access to my laptop is rather spotty :-)

NathanReb commented 6 years ago

Ok! Thanks for the contribution!