search

cryptosense / multipart-form-data

multipart/form-data (RFC2388) parser for OCaml
BSD 2-Clause "Simplified" License
19 stars 6 forks source link

Add a new parser based on callbacks #5

Closed emillon closed 8 years ago

emillon commented 8 years ago

Lwt_stream.clone is a bit difficult to reason about, so this new implementation uses only callbacks. The plan is to deprecate other functions, or maybe reimplement them in terms of Multipart.parse.

This still raises a couple exceptions here and there so more thorough tests are needed. The API may change to return a result type instead.

emillon commented 8 years ago

Cc @nv-vn in case it conflicts with what you're doing (feel free to open a WIP PR btw!)

emillon commented 8 years ago

I'll merge this for now and make improvements later.

nv-vn commented 8 years ago

Just commenting here cause I was cc'd... I've been out of town for the last few weeks and I probably won't get a chance to work on this in the next few days. Doesn't look like there's gonna be any real conflict at the moment, and I'm still planning on restructuring what I've written a bit, so nothing to worry about really. Once I feel like there's anything that works well I'll open the PR, but right now I think I need to change a few things first.

emillon commented 8 years ago

OK, no problem! Thanks!