cryptosense / ocamllint

Detect common errors in OCaml code
BSD 2-Clause "Simplified" License
68 stars 3 forks source link

Support for 4.06 #22

Open baileyparker opened 6 years ago

baileyparker commented 6 years ago

The opam package for ocamllint requires ocaml-version < "4.04.0". Is this due to AST changes? Any chances an update is easy? I'd be willing to do the legwork if this repo is still active.

emillon commented 6 years ago

Hi,

This is indeed related to AST changes. This was written before ocaml-migrate-parsetree (OMP) made it easy to support several versions of the compiler at the same time.

It should be reasonably easy to port to OMP. I should be able to find some time in the next couple weeks to do so.

(I'd like to cut a release anyway to update the rule base, and try a non-ppx approach in order not to depend on a succesful compilation)

Thanks!

XVilka commented 6 years ago

Any updates on making a new release with OMP? And 4.06 + 4.07 targets?

emillon commented 6 years ago

I think #25 was almost ready, not sure why I didn't finish the PR.