Use separate integers package and ctypes >= 0.12.0

cryptosense / pkcs11

OCaml bindings for the PKCS#11 cryptographic API

BSD 2-Clause "Simplified" License

22 stars 6 forks source link

Use separate integers package and ctypes >= 0.12.0 #54

Closed bbc2 closed 7 years ago

bbc2 commented 7 years ago

This brings us closer to a ctypes-independent package, should we need it.

bbc2 commented 7 years ago

Anything else that should be fixed?

emillon commented 7 years ago

the opam constraint is superfluous (implied by the bounds on ctypes)
the package(integers) implied by ctypes' META
not sure about .merlin but I think it uses findlib, so it's not directly useful either.

This leaves only the version bump on ctypes. I don't think this is worth adding while separate compilation is not possible, and it will be easy to add at that point.

bbc2 commented 7 years ago

To all three of your bullet points: As we use the integers package directly, I'd have thought an explicit dependency would be in order. Don't you think?

emillon commented 7 years ago

OK, that makes sense. We have couple missing dependencies as well: zarith comes to mind, but maybe something else pulled through key-parsers.

Merging, thanks!