Don't parse EC parameters and point

cryptosense / pkcs11

OCaml bindings for the PKCS#11 cryptographic API

BSD 2-Clause "Simplified" License

22 stars 6 forks source link

Don't parse EC parameters and point #58

Closed bbc2 closed 7 years ago

bbc2 commented 7 years ago

In particular, don't return CKA_CS_UNKNOWN if the parsing of EC parameters or point failed. The use of CKA_CS_UNKNOWN is reserved for codes unknown to the library.

emillon commented 7 years ago

Two small remarks mostly to self:

this triggers #42
build failure is due to ocaml/ocaml-ci-scripts#172

bbc2 commented 7 years ago

Should be good now.

emillon commented 7 years ago

Looks good, thanks. If you rebase your branch onto master this should fix the build (I allowed failures on 4.02.3).

bbc2 commented 7 years ago

I just did that.

emillon commented 7 years ago

Thanks! ✨