Point of view changes when using ui=html and clicking on "edit"

[Bullauge]

Clicking on "edit" in ui=html mode sometimes changes your avatars point of view to the upper right which is slowing the building process (a lot) and which is confusing for new users.

[bnolan]

Is this something to do with when we release pointerlock and render the element, then focus it?

[bnolan]

The buggy code might be somewhere in tools/feature.ts in the editFeature method - maybe in here?

    if (wantsHtml5() && f.constructor.Editor) {
      this.highlight()
      this.openEditor(f.constructor.Editor)
    } else {
      ui.show(f.edit())
    }

[bnolan]

Hey, we can't replicate this at the moment @Bullauge - are there some specific replication steps that cause it - or a particular browser?

[Bullauge]

Hey Ben, i used Chrome on Windows 10. Placed images at wall. Than tried to edit and pointer switched. Sometimes it works, sometimes not. Maybe place images in all sky directions and try to edit via ui=html. I have the feeling that sometimes the angle your avatar has to the image triggers the bug.

Ben Nolan notifications@github.com schrieb am Fr. 31. Jan. 2020 um 00:02:

Hey, we can't replicate this at the moment @Bullauge https://github.com/Bullauge - are there some specific replication steps that cause it - or a particular browser?>

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/cryptovoxels/issues/issues/73?email_source=notifications&email_token=AOGIQOTXCCXJQLV37XYL6ITRANL7RA5CNFSM4KC5D4G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKM4IZY#issuecomment-580502631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGIQOQRWQKE7A7Y67WOMWLRANL7RANCNFSM4KC5D4GQ .

[bnolan]

Hey @moritree can you try and replicate this issue and show it to me?

[bnolan]

Fixed by being careful with focus() and blur()