search

crysalead-js / dom-layer

Virtual DOM implementation.
MIT License
30 stars 1 forks source link

'key' in Text() does nothing #3

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hi, @jails I'm still studying your code here because I like your work! Anyway. The Text() function, you got a second argument there - key. This key are never used. What is the plans for it?

jails commented 9 years ago

Indeed it's a mistake, Having a key property for Text node doesn't make sense, I removed it. :+1:

ghost commented 9 years ago

@jails Ok. Btw. There are also other places where you have arguments that have no real purpose.

Here is another example: https://github.com/crysalead-js/dom-layer/blob/master/dist/dom-layer.js#L82

Couple of others:

https://github.com/crysalead-js/dom-layer/blob/master/dist/dom-layer.js#L5 https://github.com/crysalead-js/dom-layer/blob/master/dist/dom-layer.js#L50

This node have no real world purpose has it?

jails commented 9 years ago

Good catch :+1:, I did a couple of refactoring and I forgot to remove them removed in https://github.com/crysalead-js/dom-layer/commit/acca111a95ff6528c8829f7b3aa450051afc2f81.