search

crysalead-js / sql-dialect

SQL Builder
MIT License
6 stars 2 forks source link

Fix insert values and limit offset example #2

Closed hexetia closed 5 years ago

hexetia commented 5 years ago

I just tried to insert an item into the database but it did not work, because the insert example was wrong, so I went to look at the tests and saw that the api was slightly different instead of an array with keys and values, the api correct is that with an object with keys and values

https://github.com/crysalead-js/sql-dialect/blob/93aa1ffc80a803ac9f43ac1856aef89b470285c3/spec/suite/statement/insert.spec.js#L14-L17

https://github.com/crysalead-js/sql-dialect/blob/93aa1ffc80a803ac9f43ac1856aef89b470285c3/spec/suite/statement/postgresql/insert.spec.js#L16

https://github.com/crysalead-js/sql-dialect/blob/93aa1ffc80a803ac9f43ac1856aef89b470285c3/spec/suite/statement/mysql/insert.spec.js#L16-L17

jails commented 5 years ago

Thanks for the head up !