search

crysislinux / vscode-openjscad

An extension to integrate OpenJscad(v2) with Vscode
7 stars 6 forks source link

Crossplatform autoreload #6

Open KillyMXI opened 3 years ago

KillyMXI commented 3 years ago

Fixes #5

tsuckow commented 1 year ago

It's really sad that 2 years later, this PR is the best development experience for OpenJSCad v2. If I get a chance I'll see if I can figure out how to modify the "desktop" election app logic into this extension.

crysislinux commented 1 year ago

Sorry guys, I am no longer using OpenJSCad, I am not very good at Math so it's always a bit hard for me. I want to add other maintainers if anyone wants to maintain it. Not sure if it's still relevant since the codebase is a bit old now.

tsuckow commented 1 year ago

I think it is a convenient starting point. It should be a tribute to you that what you started is still the most streamlined setup.

As for math, I'm looking into cheating and using convex hulls, you just define the corners (cubes, spheres, etc) and it fills in the middle. But I'm not building gears and the like.

I (or any other intrepid developers) just need to channel my inner webpack (been like 2 years since I setup a web project) and try to migrate to the npm packages for jscad.

Once someone gets a working version with npm, then it's probably time to discuss how to handle maintenance.

KillyMXI commented 1 year ago

Maybe in a different situation I could've picked up this project. Modeling for 3d printing seems like something from long gone peaceful past.

Discussion in #5 outlines some serious issues and shows that this code might be not a great starting point. If I were going to create something future-proof - I'd have to start from exploring up to date openjscad code architecture and consulting with openjscad developers. VScode API also evolves over time.

Jumping off this project might be slightly better than from scratch, but it is still too much work. Starting from scratch would be preferrable from the license transparency point of view - this code includes some parts whose origin is not well traceable.

Either way, I understand the scope of the project any my current limitations, so I can't afford to start it in a foreseeable future. Even though I love openjscad idea and think the developers are wasting their effort by not understanding the importance of vscode extension approach over web or standalone clients.

crysislinux commented 1 year ago

@KillyMXI Yes, it's better to cooperate with the jscad developers and start from scratch at this point. As I said in https://github.com/crysislinux/vscode-openjscad/issues/5#issuecomment-874102640, this project extracts some code from the official jscad website, and turns them into a more modular and oop fashion. It has been two years, the official developers was trying to make some reusable packages when I started the project, maybe those packages have become much better now.

tsuckow commented 1 year ago

The published npm packages still leave something to be desired, but at least for rendering appear to be sufficient.

I haven't wired up passing a script from vscode into the webview but if I hardcode a script into the webview I can render it and at least in Chrome panning/zooming is quite responsive.

image