Thank you for this effort!

crysknife-io / crysknife

Dependency Injection and html templates framework for J2CL. Relaxed implementation of Jakarta CDI

Apache License 2.0

27 stars 8 forks source link

Thank you for this effort! #3

Open hrstoyanov opened 5 years ago

hrstoyanov commented 5 years ago

@treblereel thanks for looking into this!

Not sure if you know, but Errai has full CDI implementation with all scopes. It is based on the old GWT linker/generator mechanism, but there is a branch with CDI implemented with apt done by @tiagobento, but was never merged. Also, keep in mind APT is no longer recommended, but Dagger2 is good enough.

Hope you can steal the code and make it work with J2CL as Errai seems abandoned.

It maybe asking too much, but another Errai piece worth salvaging is the JAX-RS implementation, especialy if it is aligned to Microprofile REST Client - they are very similar in design

tiagobento commented 5 years ago

Thanks for the mention, @hrstoyanov.

As you might know, Errai's migration from GWT generators to Java APT initiative was put on hold due to higher priority tasks that came up.

Not sure if I misunderstood your comment on APT, but as far as I know, the deprecation targeted only the implementation-specific classes under com.sun package related to Annotation Processing. As far as I can tell, anything under the javax namespace is still supported.

Anyways, @treblereel, if you're interested in the efforts we did, please reach out to me, it'll be a pleasure to chat about that.

treblereel commented 5 years ago

@hrstoyanov Thanks a million for your interest, i am pretty familiar with Errai, i did some PRs to this amazing framework, i really love it, but, you know ... :(

@tiagobento yeap, i know about the work you did and as i heard, it ll never be merged, and it's very sad. I will be happy to chat with you about your experience, but at this moment i am out of the office -- PTO is nice :)

Anyway, it's just a POC to check how it could be done with APT and J2CL

hrstoyanov commented 5 years ago

@treblereel @tiagobento @mbarkley

... CDI aside, there are other Errai parts worth salvaging!

What can be done to save Errai - it really hurts to see it dying?

To me, Errai 5 needs:

Be allowed to break compatibility with Errai 4. Errai 4.x.y can continue to serve existing clients and be bound to GWT indefinitely.
Completely move Errai to Github, including issues management, discussions.
Completely switch to J2CL and Elemental only. Break things if you have to, take to opportunity to improve.
Reduce scope to only: CDI, Microprofile REST Client, WebSockets, Data binding, UI
Remove everything else - JPA, Security, RPC, messaging, HTTP polling...
Make standard Microprofile APIs/JAVA EE maven artifacts the only dependencies.
[Optional] Implement Spring CDI and REST interfaces.

Reducing the scope of Errai, making it smaller and more focused is key to success (compare to the reduced J2CL vs the bloated GWT)